SOME UNIQUE C++ CODE! // Pacman Clone Code Review
To try everything Brilliant has to offer-free-for a full 30 days, visit brilliant.org/TheCherno. The first 200 of you will get 20% off Brilliant’s annual premium subscription!
Patreon ► / thecherno
Instagram ► / thecherno
Twitter ► / thecherno
Discord ► / discord
Code ► github.com/LucaFeggi/PacMan_S...
Getting started with Git ► docs.github.com/en/get-starte...
GitHub Desktop ► desktop.github.com/
Hazel ► hazelengine.com
🕹️ Play our latest game FREE (made in Hazel!) ► studiocherno.itch.io/saving-c...
🌏 Need web hosting? ► hostinger.com/cherno
💰 Links to stuff I use:
⌨ Keyboard ► geni.us/T2J7
🐭 Mouse ► geni.us/BuY7
💻 Monitors ► geni.us/wZFSwSK
This video is sponsored by Brilliant.
Пікірлер: 501
Code Reviews are back! Hope you guys enjoyed this episode ❤ Don’t forget you can try everything Brilliant has to offer-free-for a full 30 days; visit brilliant.org/TheCherno. The first 200 of you will get 20% off Brilliant’s annual premium subscription!
@nerdastics3987
10 ай бұрын
i love that in c++, there isn't one single defined way of doing things. i mean, there are standards, but i love it that I can combine c-style code with object-oriented code without much of a problem. Its like using linux but in a programming language
@nerdastics3987
10 ай бұрын
People who cancel the goto are the same ones who cancel the raw c-style pointer, they're just scared to deal with the low level stuff.
@nerdastics3987
10 ай бұрын
although this is coming from me, someone who uses a heavily modified version of old-fashioned quake and doom's zone and hunk allocator with c++ objects
@nerdastics3987
10 ай бұрын
anyone who says non-inlined functions are bad and reduce performance should read quake3's source code. That thing doesn't inline almost anything yet it could run at 333 fps on 1997 computers with pretty decent (even for today) graphics.... (which is better than some games today)
@nerdastics3987
10 ай бұрын
out of all the horrid things EA has done, the EASTL is where they truly shine
Writes a goto - "I'm probably going to get canceled for this." LOL
@samanthaqiu3416
10 ай бұрын
I think the hate against goto is way overblown and uses like this help make the code more readable, not less. However this could also be solved with a scope guard
@Surf_Cat
10 ай бұрын
@@samanthaqiu3416 True, look at nginx. The code is littered with them at places for a reason.
@skeleton_craftGaming
10 ай бұрын
If you go deep enough all loops are defined using goto.
@Asto508
9 ай бұрын
@@skeleton_craftGaming That's the "if you go deep enough, everything is just 0 and 1" argument. True, but not necessarily useful.
@therealvbw
9 ай бұрын
@@Asto508 It does at least prove that the end result should be the same
When I worked at a "triple-a" game studio, we had a build system that would effectively produce what you were calling "unity builds" when producing non-debug builds. I can't remember the exact numbers, but it'd take around 3500ish cpp files and compile them in something like 8 to 10 translation units. It *drastically* reduced the amount of time spent linking, but took heaps of memory to accomplish. Debug builds just relied on incredibuild and spare cycles on artist's machines to compile quickly, but linking could be a real pain sometimes! Incremental building with edit and continue was a godsend.
@NolaanOne
10 ай бұрын
That's the main reason you'd use unity builds. I've implemented one for a company where the builds were starting to take so long it would impact the development process.
@gmfCoding
10 ай бұрын
I thought the apart of the point of having multiple cpp/translation units is that when you need to recompile it will only recompile files that have been modified? There for you save compilation time by only having to recompile the necessary files, say for example with the 3500 source files split of 8 final translation units. If you needed to modify one of those sources files it will now have to recompile 3500/8 (430) source files in-order to compile that one change source file? Does combining 3500 sources files into 8 translation units and linking them out way compiling 3500 source files into 3500 translation units and linking them?
@nytheris2848
10 ай бұрын
@@gmfCoding Compilation is faster than linking by a lot. I've played around with some C projects with hundreds of thousands of lines of code that compile in about 3 seconds and barely do any linking because they only use a single translation unit and include everything in the main.c file. In fact, one of my own projects used a single translation unit for a while, but as it grew, visual studio started to complain more and more. So I switched the whole thing to a bunch of separate translation units and it slowed the builds down by about 3 or 4 times, even if I had only made a change to one of the translation units.
@TurtleKwitty
10 ай бұрын
@@gmfCoding That is the point yes, but for final release builds you tend to do a full clean build to ensure the compiler/linker can do all the optimizations and there's nothing can can possibly corrupt built files in the downtimes etc etc. Building less files makes a clean build faster so it's good for that final release build step, but yes incremental builds are better for small changes hence why they kept all the files seperate while working on it and only did the compress into less files for the release.
@NyanCoder
10 ай бұрын
@@gmfCoding In the release builds most of the times you'll build the whole project just because the amount of changes is very big (and some header files when changes forces to rebuild a lot of object files), so unity builds in this case are more than preferred (cuz overall build would be much faster), but during the development when changes are small, non-unity builds are faster (it will take a little time after merges/pulls but in the rest of the time it'll build in seconds). But you know what? It depends. I think in some cases unity builds can be faster in both cases (but in the product where I used to work year ago it wasn't the case)
+1 for state machines, always looked quite cumbersome in Oop patterns books so would be good to see it done here.
@CallousCoder
10 ай бұрын
Yeah state machines shouldn’t be done in OOP Most games therefor don’t need OOP.😂
@anon_y_mousse
10 ай бұрын
@@CallousCoder I don't think it's so much the use of object orientation, but rather the overuse. Most game engines are giant bloated messes, but it doesn't happen in one go, it takes time for that cruft to build up.
@CallousCoder
10 ай бұрын
@@anon_y_mousse absolutely agree.
@demonking2526
10 ай бұрын
@@CallousCoderI use OOP for state machines. The FSM I use uses Polymorphism to do state transitioning from one to another. Starts with a state base class, all necessary state classes derive from it. Then you have common virtual methods such as Enter, Exit, Update and Draw which are defined in base, then each derived class overrides those methods. OOP is EXTREMELY recommended for an FSM
@CallousCoder
10 ай бұрын
@@demonking2526 It makes something that is so trivial unnecessarily complex and harder to test all paths properly. I am ditching the whole OOP mindset more and more, the older I get and going back to the old school procedural way. Which is cleaner, easier readably (maintainable) , faster and uses less memory. And most importantly for us, it's easy to prove something is correct. I usually deal with mission critical real time systems in energy/trading and medical. And OOP has been a pain to prove correctness in order to get things certified. Ditching OOP upped my (our) output significantly because it's trivial to prove correctness and timings. So screw OOP I will no longer use it unless it solves a real problem. Which usually it doesn't do, especially not in controlling hardware systems. But I like your thinking!
The goto usage at 17:15 is EXACTLY what a good goto is for: breaking out of nested loops. This removes the need for additional conditionals and probably outer loop variables.
@obinator9065
10 ай бұрын
you're still a mad man if you use goto DON'T YOU DARE OR KAISER WILHELM WILL BE MAD
@propov1802
10 ай бұрын
Moving the SDL_PollEvents to it's own function that's a bool could do the trick too.
@qqshutup7175
10 ай бұрын
I have never used SDL, but it can be condensed into: // any other more appropriate name bool PollEvents() { SDL_Event event{}; while ( SDL_PollEvent( &event ) ) { if ( event.type == SDL_QUIT ) { return false; } // handle any event HandleEvent( event ); } return true; } ... while ( PollEvents() ) { // game logic, rendering, etc... }
@Tsukinoura
10 ай бұрын
i was wondering in this case can't we just use return to exit the whole thing ?
@justgame5508
10 ай бұрын
@@TsukinouraNo because some code still has to be executed before returning
Would definitely be interested to see your makeover of this clone and also a video on state machines in general. You got my vote for that.
@mattice9083
7 ай бұрын
aye. and my axe
There's a relatively new option in VS, called "Sticky scroll", that makes reading nested code like this much easier (for those of us who like functions to have a single exit point). Its description is "Group the current scopes within a scrollable region of the editor window" with options to set the number of scopes to track and whether to prioritise the inner or outer scopes. It basically means you always know what class, loop, if(), etc. you are looking at without having to scroll backwards (or hover over the curly braces, like you used to have to). Thanks for the videos. Stay safe out there.
@AURORAFIELDS
10 ай бұрын
That is amazing! I definitely didn't know about this. Even though I'm not particularly fond of messy logic or functions with load of crud in them, sometimes you just inevitably end up with messy code as a result of really complex logic that is hard to pull apart. I'll definitely have some use for this~
@irishbruse
10 ай бұрын
Its in vscode too and its amazing so much better than the crumby breadcrumb bar
@anon_y_mousse
10 ай бұрын
Neat, I guess. I use vim to edit code, so to keep something in mind like that, if I needed to, I would just create a split and scale it down to one line then scroll down. I suppose I could write a plugin to have it do so automatically and clean up as I leave a scope, but I don't tend to write 42 levels of nesting.
@Turalcar
10 ай бұрын
This might be me being a boomer (technically a millenial but whatever) but I prefer to write code that can be read with minimal intervention from the editor. (Syntax highlighting is ok, I guess).
@arijanj
10 ай бұрын
This is usually called code context
Edit: Please ignore this comment, the author was confused with a feature from another language. Hello, there is an alternative to the goto used at 17:18. You can put a label before a while (or any loop statement) and used the instruction "break LABEL_NAME;" from any nested while to break the NABEL_NAME while. It also work with "continue LABEL_NAME;" I don't remember wich c++ revision impltemented this features.
@supercyclone8342
10 ай бұрын
Oh, that's really good to know
@bamberghh1691
10 ай бұрын
I don't think that named breaks are in C++, maybe you're confusing it with the Java's named breaks?
@nelsonperrin5800
10 ай бұрын
@@bamberghh1691 I've been looking for a source for 20 minutes now, and indeed, this feature ("named break/continue") is present in various languages but not in any version of c++. I was convinced I'd seen this feature in an article about c++20 or c++23, I apologise for the confusion.
@Brad_Script
4 ай бұрын
breaking to labels only works in java and javascript
My mind has been so poisoned that I thought "pacman" referred to the Arch package manager.
@yusinwu
10 ай бұрын
Once i was following a tutorial installing wine on my Ubuntu, I accidentally followed a tutorial written for Arch. At some moment i *sudo apt install pacman* in the terminal and the game poped up. Imagine my confusion as a Linux newbie!
@anon_y_mousse
10 ай бұрын
I've been thinking about writing my own package manager, as I would like to implement my own OS, and I was considering calling it Tetris because the game involves packing misshapen blocks into tight spaces. Or would that be too evil?
@SolidSt8Dj
10 ай бұрын
@@anon_y_mousse Go for it.
@user-qv5ko8qk4r
9 ай бұрын
Same and I was disappointed
I do really enjoy the entire series of a section of code where it's not just "I think this is bad and for this reason" but you also get "and here is how I would do it along with why I would do it that way." I struggle with doing code reviews professionally because of the emotion people bring to my comments. I always explain the "why" and give examples of what they could do instead but it hasn't helped. For anybody having their code reviewed by others, either professionally or in this kind of setting, the reviewer isn't saying that YOU are bad. Your code is not an extension of you as a person. The thing that may be bad is the code. At the end of the day we all want well written code. We just disagree of what well written code is.
Definite yes to both tutorials you mentioned, especially the project to Visual Studio conversion. Would love to see it.
About all the code being in header files: it looks like all of this could be properly split into header/source files, but it just reminded me of working with templates. You were SUPPOSED to write the header with template references, then write a source file for every possible data type that would be handed in. My library was more about storage, efficient access, all that fun stuff, so I literally didn't CARE what the internal data was because I didn't touch it. I found out that you were allowed to put code inside the header file to make it uniform across all implementations. so I just put ALL the code in the header. The IDE yelled at me for not having a source file, so I gave it an empty source file. The library worked fantastically, and I went on to use it in quite a few of my projects because it simplified handling things like unicode, pointer arrays, stuff like that. Is it RIGHT to do it like that? No. Was I planning on going back and doing it right? Never.
I first stumbled on the idea of grouping C++ files together for build speed around 2001, as a way to speed up Warcraft III builds (heavily templated, compilers of that era took forever). I called it bundle files, and then used it later internally to distributed shared libraries in source form instead of DLLs. And then years later I find out other people were calling it unity builds, and eventually Unreal put it into their build system, and so did Meson, so here we are.
OMG I would die for that next video. I've been so incredibly overwhelmed with the ways to organize a project that I have never made an actually big project. Love this channel
Love the review, even though I'm not a C++ programmer in the slightest. Would love to see the state machine video that you suggest making. Maybe a refactoring series on your improvements/changes to a codebase as a game developer if you're up to it too?
super interesting to see code formatted in such a way, as a learner id love to see a more proper conventional way. Looking forward to the state machine/refactor video!
Would love to see you work through this turning it into a state-machine etc, definitely something I feel would be useful to watch the process of along with the logical steps to move from this to a well structured program.
I've been working on a game engine as a small hobby for some years and by accident, I included like this. I then stumbled upon weird linking errors and eventually dropped the project. It took me a year to understand c++ better and realize what I've done. It was such a pain in the ass to restructure the entire project. The Project is much better now and no more weird bugs, thank god
I loved this video so much I went in search of the follow up thinking this was an older video, so sad I have to wait.
"one might argue functions calls are bad because of performance, which is ridiculous in this case" Thank you. Far too many people try to argue this as a reason for having the longest functions known to man.
That type of project setup is quite similar to what Casey Muratori does on Handmade Hero
@ar_xiv
10 ай бұрын
he's the king of no preemptive organization at all. keep the entire project structure in your head at once, understand all of it at once and at all times, don't make your life easier at any point :p
@sevi602
10 ай бұрын
@@ar_xiv What do you mean by that?
Yes please. A video on the refactoring of this code to make it beautiful and using a finite-state machine would be excellent. Thanks.
I've seen this coding style being used by other experienced programmers - that is, not having headers, including all the other CPP files directly, and compiling as a single unit. For example Casey Muratori, who is a seasoned game and graphics programmer, has a video series called "Handmade Hero" where he extensively demonstrates this coding style. The advantages are: very quick compile times, and arguably it's actually simpler, because you don't have to make separate header files.
@user-cy1rm5vb7i
10 ай бұрын
you can compile the unit files in parallel and then link'em. That can be even faster than unit builds PS you can even replace unit files with c++20 modules, that would speed up compilation even further
@anon_y_mousse
10 ай бұрын
If you edit all the files at once then sure. And yeah, all the boilerplate code does suck, but if you only edit one module it's much faster to recompile because `make` and other programs like it take the file's modification time into account when deciding what to rebuild. So it would just compile the one file you modified, then call the linker with all of the object files that have already been built and you're done.
When you mentioned that whoever made this probably came from a different language like Java or C#, that made me chuckle. It really does look like they were trying to write C++ code in more or less exactly the same way as those other languages
y'know, when all is said and done, setting stuff up with gcc and make is much easier than setting up a project in visual studio
I think this very easy and understandable architecture, and if you write some simple small project like this one, you do not need to divide it into separate translation units i written one plugin once in the same way )
Love to see the state machine. Also, the creating project you asked us to mention
Sometimes I don't understand the world anymore... Somebody can code a game clone that looks that good, but then they don't know how to use Git???
@lengors7327
10 ай бұрын
Im gonna assume they were just trying to give cherno enough content for a lengthy video 😅
@Ruhrpottpatriot
10 ай бұрын
I have multiple colleagues who develop software for unmanned aerial systems which have specs that PCs had in the 80s and they are damn good at it, but their git repositories? Oh boy.
@Stroopwafe1
10 ай бұрын
They are 2 unrelated skillsets. Sure, they sometimes go hand-in-hand but someone who's good at git can be terrible with code, and someone who's good at code can be terrible with git
@ThatAnnoyingGuyOnTheInternet
10 ай бұрын
If you code just for yourself, as a hobby, there is no real need to use Git (or similar tool). "use this maingame v2 backup fixed.cpp" is a perfectly valid filename.
@Entropy67
10 ай бұрын
I would say the lack of experience does show in the code (since everythings in header files lol), however this guy is truly great if he can navigate that code and write such a game. Just inexperienced for now...
A state machine video will be great!, I will also love to see a "To OOP or nope, thats the question" video. Particularly when-yes/when-not (environment, kind of proyect, etc) kind of approach. BTW, I'm an embedded programmer (for hobby).
Thank you for such great content! Can't wait to see this exciting state machine approach!!
Another way to avoid the double break is to move the update loop into a function and use return.
@XlearRetroWave
10 ай бұрын
also surprised me. return is the only right way in this code situation
The code you review almost always looks so simple and then when you dive into a C++ code base it's like night and day in terms of how complex C++ can get
@colleagueriley860
10 ай бұрын
Not really complex, just abstract and dumb. A lot of C++ features cause both compile time and performance to worsen.
@user-ge2vc3rl1n
10 ай бұрын
@@colleagueriley860 that's the same thing in different words.
@colleagueriley860
10 ай бұрын
@@user-ge2vc3rl1n no, I’m saying complex is like memory/pointers. They’re complex but can be understood and have a rational purpose. Many C++ features are just pure bloat and have really poor syntax and a negative effect on performance
23:00 better use guard if statements to reduce indention
Just a few minutes in, I just wanted to note for what it is worth "#pragma once" although it is widely supported it is not part of the official C++ standard and if you value the portability of your code or would prefer to strictly adhere the C++ standard not compiler implementation you should avoid using pragma and use the standards conformant "#ifndef, #define, #endif".
@yokozombie
9 ай бұрын
by that moment if your compiler does not support pragma once, you need to think about changing compiler (unless shakled to exotic platform)
I'd love to see ECS architecture pacman
A git tutorial in increasing depth as the video progresses would be good. Starting with the basics like initialising a repo, configuring settings for the repo, adding files to the staging area, etc. Then moving up to branching making changes, merging back onto another branch, resolving conflicts, etc. That would make for a good video I think! There are videos like that already but they tend to drone on quite a bit. I think your style, presentation & way of explaining things in simple terms would make for a much more captivating and useful video for most people. :)
@TheExileFox
10 ай бұрын
That really needs to include the awful pitfalls of things like "detached head" and other situations a beginner may struggle to resolve
@merlinwarage
10 ай бұрын
I mean... git is pretty well documented with a lot of examples.
@2khz
10 ай бұрын
@@merlinwarage Lots of the documentation can be quite terse with regards to the technical jargon. I can't imagine a beginner understanding much of the terminology.
My note: You have to declare all of your header files into a different cpp program and then declare .hpp inside it to make use of it not only in a single cpp file but also in other files....also as cpp has a top down aproach, it becomes compulsory to write the cpp header in an order,so it is probably not good to write headers inside a single file
Unity builds are actually pretty great; faster compile time and less files to manage. Personally though, I'm not a fan of using header files for unity builds, or for "single-header" libraries for that matter. I'm of the opinion that if you plan to include declarations along with definitions, then you should put that into a .c/.cpp, not .h file. That way, if someone else happens to take a look at the project, its abundantly clear that what you're doing is merging source into a single compilation unit. Even for just that embedded data (char array), I would have that as a separate .cpp file that gets included where necessary, but that's usually because I have a program I made that converts images and binary formats into C source that can be embedded into a project.
@sortof3337
10 ай бұрын
i love single header libraries. this way I have single entry point into my library
+1 for the Git/Github tutorial! Hahaha I'm a beginner and have been messing with it a little bit but could definetly use a "good practices" video on that :)
I think a video on creating a visual studio solution for a codebase would be very useful
Doing a walk through our setting up a VS solution is a very good idea!
@theairaccumulator7144
10 ай бұрын
He did one already
@wjrasmussen666
10 ай бұрын
I'd like that too. Since he asked for this in the video.
I have been programming for 30 years, and I still start my C programs in a similar way... I'll start out with one file main.c and then I'll add a header when I start to factor out chunks of code. But that header will contain the functions that I'm stripping... And then another file or two in a header... And then after about the fifth or sixth finalize break it all down into headers and c files. Absolutely drives one of my friends completely batty when he sees me doing this. It's like calm down most of my coat is a spike I don't care what happens to it next week :p
@colleagueriley860
10 ай бұрын
C compiles so fast that you don’t even need a source files half the time. (Assuming you’re programming in an efficient way)
Wow this is just what I needed! I'm making a pacman clone myself.
Not a programmer here (not a professional one at least). I'm a 2D artist and i feel like the talk about different languages in different situations is close to me too lol. How you implement all the basics and sctructure your work to become something new, interesting and unique, that works for the thing you're building is close to any creative endeavor.
We definitely want to see you set up those files in visual studio
Very very interested in the state machine stuff!!! Please bring it on.
I've cloned Pacman for multiple platforms, including various mobile phones, microcontrollers, and Javascript. There are a few gameplay things that are missed here that I noticed immediately: Key-presses/joystick input should set the direction Pacman should try to move in next frame. If it cannot move in that direction it will continue in its current direction. Also it should never stop moving unless it hits a wall (and has no pre-loaded next direction). The ghosts actually have the same logic. Ghosts never reverse direction, unless a power pill has just been eaten. The ghost's eyes should point in the direction they're moving Pacman should stop briefly after eating a ghost, while the sound effect plays - it just make it feel better :) In this game the pills are being eaten before Pacman is actually centred over them, which is not quite correct - he should be centred over the pill before it's eaten as it feels better again :) The ghost patterns are wrong, but honestly I don't care about that. In the real game each ghost has its own logic. Nice submission though, keep it up!
@corellioncrusaderproductio4679
10 ай бұрын
Even in the original, Pac-man doesn't eat the dot when centered. It's just eaten as soon as he enters the tile that contains a dot, similarly to how the ghost detection works. If you go frame by frame, you'll see it disappears from inside his mouth.
Hey, please do make a visual studio setting up/ configuration type video. I have always thought Visual studio was kinda complex but watching you use it I wanna use it but it would be great to watch how you have/set up a project.
Love the review! ❤ I 'll wait with anxious the state machine
Great video! I'm excited for the state machine.
@indierusty
10 ай бұрын
Yes that will be great too.
A detail, you really shouldn't prefer to use pragma once over ifndef. Ifndef is in the standard while pragma is compiler dependants.
@anon_y_mousse
10 ай бұрын
True, though since gcc supports it I find it an acceptable method. Basically, any feature that gcc supports, since it's free and open source, I find acceptable because literally anyone can download and use it on nearly any platform, and there are cross compilers for gcc that can target some old and strange platforms which other compilers ignore.
@ezekieloruven
8 ай бұрын
Please name a compiler in industry use today that doesn't support pragma once. I'll wait. Pragma once is literally better supported than a lot of actual C++ standards.
I thought state machine too as soon as I saw the nested-ifs. Interested if you implement it via polymorphism or some other way.
Great achievement without abstraction or scalability. Thanks for the video. This is very educational.
I'm looking forward to the state machines video! Can you quickly mention all the ways to solve deeply nested code, as the one in Terraria? One common strategy I use is having guard statements.
Yes definitely interested in state machine and improvements to this project.
Finally the State Machine video. I'm working on something same, so Honestly I would love, you making this little project better;
"you KIND-OF just combine it all into LIKE a single file, a single KIND-OF c++ file, that then you send to the compiler as LIKE a single translation unit. so that is effectively KIND-OF of what we have here because these are the only KIND OF source code files" this is way too much 'kind-of' and 'like', so esp. for people who want to learn, it gets really hard to understand what the message is about - kind of :) files are files, if they are 'kind of' files a compiler will spit out lots of errors, or 'like kind-of' warnings kind-a-like-a
@atlantic_love
10 ай бұрын
Agreed. The guy just blabbers and blabbers and doesn't really teach anyone anything.
Definitely looking forward to the next video! This gonna be fun!
Cherno, it would be nice to see you do a Git tutorial. I understand it enough to do some basic stuff but it gets real dicey real quick where I am unsure if I am going to screw something up real quick. Like I can do basic push/pull/commit.
@toby9999
8 ай бұрын
Yeah, Git is a nightmare when used for anything more than you described. I've been struggling with it for two years since we switched from SVN.
Im looking forward to see your way of doing state machine. Please don't forget to do it :)
I like the way they did their code with the header files its actually easier to read and find things rather than put a bunch of files everywhere and scramble to find what you are actually looking for. Edit: 8:46 That is the point of why it was also used for only 1 file not sure why that is such a bad thing when the project just works
omg, that was actually the first time i ever saw a good reason to use goto!
instead of a goto.. put the execution loop in a function and return on quit. No need for multiple breaks, no need for gotos, stack things get cleaned up, etc etc
hey, what software did you use to draw on the screen at 10:02 ?
Yes is it absolutely worth doing a git tutorial, please and thank you
What are you using, where you explain certain things with drawings? Is it part of VS?
Kudos, Pac-Man clone maker! Very well done!
Nifty clone for sure & the possible ways to clean it up were well stated imo. & I'm Defo for the state machine vid.
That's the kind of a code review we all want to obtain🎉
Great! Did the State machine video got done?
At 17:00, the dreaded 'goto' statement. A reminder to the computer science zealots, branch statements are used in assembly all over the place by the compiler, aka a 'goto' statement. I use them when it simplifies the code, like in drivers, etc. I won't cancel you. 😆
@dysfunc121
10 ай бұрын
Would you want somebody working on your own systems (not you yourself) to have this energy when they work on your codebase?
@merseyviking
10 ай бұрын
Just because assembly has the equivalent of goto, it doesn't mean your higher-level language should use them. If you want to use all the features of assembly, program in assembly.
@glee21012
10 ай бұрын
@@merseyviking yes it’s far easier to exit a complex state environment with overly complicated if, then, else, flags to break out loops. I only use a goto statement when it’s deliberate, makes it easier to read the code. Your argument is rubbish. I’ll code the way I do, you do you . I don’t care.
@glee21012
10 ай бұрын
@@dysfunc121 I have absolutely no idea what you are talking about.
@dysfunc121
10 ай бұрын
@@glee21012 I'm asking would you want people working under you who do not know everything you might to use it. You had absolutely no idea what was meant? Even if it wasn't clear to you, it's plain English, how do you solve hard problems when you do not understand?
How do you make the build output printing the errors in red color?
yes cherno can you please make a detailed video on how to make vs solution if you only have code files and can you also explain how the cmake works and to make a vs solution from cmake as well
Another +1 on setting up state machines in C++. Looking at the OOP state pattern example confuses me a bit on it. I know its intended use (have state object, do stuff based on called state), but a way to do this in C++, and in gaming would clear up some confusion. I'm writing a text based Pokemon Battle Simulator in C++ right now but haven't gotten to the actual battle engine because I want to implement them as concrete states (there are SO MANY states and the order of which they execute in Pokemon on a single turn that it's ridiculous: status effects of when they happen inside a turn, move priorities, held items happening either before or after an attack, abilities happening before a turn, after attack, after hit, after turn etc). Instead of writing so many if/else statements, it would just be a lot more clear to set each of these up as states and control when they happen in the flow of battle.
Guide on setting up not-vusial-studio project in visual studio would be great!)
Thank you for standing up for goto you give the most convincing case for switching to CPP from c
It’s actually very clear and neat:3!
24:55 - WE'RE DEAD! :D This is gold.
need an urgent refresher on setting up projects using cmake and cmakelists
The header/implementation structure reminds me a lot of the PSR4 Structure in PHP.
i am excited for the state machine idea
Wow, it reminds me a lot of the code I used to write when I first started C++, but nowhere near impressive. Good job to this guy!
Surprisingly this code is smart in it's use of simple approach. Kinda like it ngl. If I don't have plans for reusability or shared code base why not just stop jumbling with header implementation duality. It's heretic I know but I'm an engineer I am practical by nature. If you know better there's no problem if you broke the rules in my book. Btw if you use -O2 or higher optimization compiler might decide to break or goto implicitly by dead code ellimination optimization, so right usage but obviously dangerous so heresy. 😅
@merseyviking
10 ай бұрын
In general I'm not against header-only type projects, but the thing that makes me pale is the reliance on #include ordering. That's incredibly fragile.
State-Machine: absolutely! The next dev on the job will thank you.
What program do you use to draw on the screen when displaying things? Like 19:10
@avram_traian
10 ай бұрын
Zoom It
Hi Cherno, I would like to find out how to write game object classes and what the classes should contain. Thanks for your great videos!
Great work!! What color theme are you using? It looks really nice :))
Thank you for promoting goto in cases it makes things simpler and easier to read.
Why put everything in headers when you can put everything in main
Did you make a follow up video to this?
Hi, Great content in the history of C++ as always. Just one thing, your volume needs ++ a bit.
17:20 In Java you can label loops and break out of the outter loop using the label. (...basically a goto). Does cpp support this?
@anon_y_mousse
10 ай бұрын
No, and personally I'm glad it doesn't because it's a convoluted solution that basically just puts goto into the language anyway.
nested loops are NOT only bad for the developers, they are also bad for machines in terms of computation : for instance they might cause a poor performance on the branch prediction unit.
man we need cmake tutorial from you, youtube is not enough
Which font are you using for Visual Studio? Is it Cascadia Code or Cascadia Mono?
At 21:31 inside Hazel::Main why not use a unique pointer for Application?
A state machine would be very interesting.
I want to start with java, but all the compilers are so odd, and strange, do you have a good suggesstion?
When @TheCherno says "I will make a video about this" there is a 0.01% chance that its gonna happen
1:51 I would love a video like that!