hi there! just finished watching your video :) and you asked for feedback so here it comes! - i thought the code was generally good, i just have a few small nitpicks. breaking up code into function blocks is also very good and something that i feel like would have helped me a lot if i knew that earlier (rip to all my unmanagable projects) - instead of using random.randint, you can use random.choice, which takes in a sequence and returns a random element from it, which is simpler and more pythonic :) - and instead of using while padding_counter that's all! im glad you had fun making this video and im looking forwards to more python content :D

@MartinAaberge

2 жыл бұрын

Hi Eld. Thank you for your feedback! Really appreciate it :) -randint: You are so right when it comes to choice. Can't believe I missed that one. I mean, that is way prettier than using a random int as an index. Thanks. -while vs. for _ in range() : Thanks. Do you know which is faster btw? Would be interesting to know. I also use _ as temp variables, but as you say, that aint pretty! Thanks again for your comments! 🤍

@eldattackkrossa9886

2 жыл бұрын

@@MartinAaberge im glad you like the comments :D i did a quick speed test using the standard library timeit module, and it seems that using for _ in range(n) instead of while True / if temp == n: break leads to about a 15% speed increase on my machine, probably because it doesn't have to check every time

@eldattackkrossa9886

2 жыл бұрын

@@MartinAaberge note that 15% is just bc what i put in the loop itself is relatively lightweight, so obviously it depends on if most of the overhead is coming from the looping itself, but either way it's more pythonic and just looks nicer so id recommend it either way :D 🤍