Join the community: amigoscode.com/p/join-community Premium programming courses amigoscode.com/courses

@testmsf5408

2 жыл бұрын

How to add icon build? Look at it funny ^^

@youssefsuimri9526

2 жыл бұрын

I need your help plz if you don't mind. How we can stop people publish ing an image of us on Facebook and whatisup?

@babay-mp4bq

2 жыл бұрын

alhamdullillah da'wah and programming at the same time hehe

We want more of these series . It's very useful

@zoaybk

2 жыл бұрын

True, please keep them coming 🙏🏽

@salehhassan6057

2 жыл бұрын

True

@cigomba

2 жыл бұрын

Definitely learned a lot from this. I can tell you know the fundamentals very well and that goes a long way.

@parvathys6665

Жыл бұрын

True

One of my main issues when I first started learning code, was not being able to understand the logic behind the code. And everyone teaching back then only focused on making sure we memorized the style of the code instead of the logic behind it. - THIS for me, is one of the BEST part of your videos. Since you explain exactly what that code does and then, when needed, fix it, explaining exactly what the fix does. If there was a dedicated series on this, it would be amazing!! fantastic work. love what you do.

Just more of this. This was literally amazing. I enjoyed every single second of it.

This is amazing. More of this! Watching a senior dev correcting lower tier devs is so nice and a valuable lesson for us all.

Man I'm just loving such kind of videos. This teaches you so much practical stuff.

New to the channel but I love this series. I haven’t used java since 1st year of uni and it’s nice to learn about declarative patterns that weren’t taught in uni.

WOW, I started as a junior java dev about a year ago and I learned more from these videos than most of my time at work!

Actually regarding the comparator you wrote. You could just do min(Comparator.comparing(booking -> ...)) Then this would even be smaller and neater.

You are the best Trainer on Java so far in my experience. Keep rocking. Big Fan

I think no KZreadr had done this. This code reviews is so good to see. Please continue to.

@odkane

2 жыл бұрын

ArjanCodes does some nice code reviews too

Wow, I never learned so much in one video. I think the value here is you are tackling it from a professional perspective, which some of us newbies lack. Tutorials many time go around teaching things like syntax and that kind of stuff, but I believe learning best practices is really valuable. Just loved it

@codingwithcrisprg4274

2 жыл бұрын

You can tell he has robust understanding of Data structures and Algorithms.

@AmigosCode, i really love the codereview, please can you make in the future some e2e tensting tutorials, as well as CI/CD, and Cloud (AWS or GCP) pleaseee, and keep going

Thank you Sir for these videos. As junior for me your code review serie is more helpful than any courses I've every seen.

The cranberry juice caught me off guard. Instant like and sub But seriously, thank you for this resource. Everything from the shortcuts, the use of optional, and just the way you were critical about naming conventions really challenged what I've learned over the last few years in school and the bits of work where I've scripted or dabbled in some code snippets. Awesome video!

Well, I must say that modern Java looks quite neat. Greeting from dotnet :)

The code review/refactor series is great, keep it 👍

It's awesome to see that is going to be a new series :) Code review is the best way to exchange knowledge

Learning through errors correction is one of the best way to fix new things in mind ! well done

We need more of this. Learnt a lot,gonna apply this in future for sure💯

Sir Amigo, i love your segment with this reviewing some created codes, its really so informative. I wish you can have this added as part of your weekly content. Thanks so much, you are so awesome. Ive learned so much about Java language. Thanks again and more power to your YT Channel.

Amazing thanks for the help This way my first spring boot project and ive learned a lot from you !

this was really awesome, I felt like all code I've ever written was being reviewed, and it was great.

Please go on posting this kind of videos because they are amazing and full of tremendous concepts

I really appreciate this kind of videos, man you are awesome!

Extremely useful!! I don't see much video content like this... It's practical.

Even if I'am not learning Java I'am benefiting from this video, jazakAllahu khairan brother

This is amazing, we need more videos like this! Hugs from Brazil!

Best video on KZread. your videos inspire me and make me more professional. Thank you a lot

Keep up these series. This is worth every second!!

Love this series! Please continue!

Very nice code review!! I find writing static test classes that setup the entities that you will constantly test against makes life easier. I would probably also use some verifications in the test as well

This is awesome! I would suggest writing the test first and then re-factoring.

@CarlosDiaz-wh4jb

7 ай бұрын

I was going to comment that opinion as well 😀

I love the subtle arabic words you throw in

It is satisfying to watch it. Please continue 🙏

@Amigoscode this was a fantastic video. It's great to see you at work.

Wow this is a great video, also I love your hat! You just earned a new subscriber :D

thank you for this, i ;ietrally dont even know some of the built in methods used here so now i have some cool features to look into. i appreciate this. its in a way bettdr than tutorials i think

I’m not a Java programmer so please take this comment lightly. I find that at 19:50, you refactored to not return anything but I think this differs depending on the context. If the frontend needs to be aware of multiple bookings, it should return that saved booking id instead of void. This is so that the frontend can be aware of the saved booking id to then maybe later in the same form send a patch request to update the booking.

@valentinpopescu6704

2 жыл бұрын

That would be unclean code as you're adding multiple logic to one method. What you should do in this method is only book a room, like the name implies, and if you need the id, create a DAO to retrieve the id by the bookings name and optionally the start and ending date.

Disagree with listAll The class is called booking service and it only gets bookings. Calling it getAll is better because it is less verbose and you can still figure out the meaning from the class name. Same thing with delete,find,create

@rocketjack4865

2 жыл бұрын

Yep exactly

@ivanjermakov

2 жыл бұрын

Agree. Same as naming every date in entity with date: startDate, bookedDate, createdDate... It is inferred from type information, no need to type it twice.

I always like coding reviews and thank you very much for the topic.

19:25 Isn't REST standard to return 201 Created and include newly created object in the response body and URL in location header?

@cdhagen

2 жыл бұрын

I thought the same, especially because in this example, an ID (random UUID) is assigned to the newly created object. One can argue whether to return the entire object or just the URL location, but the client should receive some reference to the stored object.

@mishikookropiridze

2 жыл бұрын

Yes, 201 with object is standard

@andrewcathcart

2 жыл бұрын

Yup. 201 with the entity created. Otherwise how would the client know what GUID was saved in the db?

@Michaeljamieson10

2 жыл бұрын

Yes 201 with object

@jorgebee65

2 жыл бұрын

@@mishikookropiridze Yeah, make sense to me.

Amazing stuff akhi, can’t wait to get on that level in sha Allah😍🔥

Fair cleanup, but there are some points here that caught me off guard. 7:40 - I'm curious as to why it's best practice to only import the used types and not wildcard said package. The only "issue" there is, is that it clutters the local namespace and in reality could ONLY cause you to receive a compile-time error if there were to be conflicting type names, which can be resolved on the spot. Other than the mentioned "issue", there is no obvious reason not to do this if you're certain of the type namings. You also decrease the amount of unnecessary lines of code. 9:50 - 'listAll', 'all' or 'findAll' would be fine considering the fact that it's in a type of 'BookingService'. The type of listing is already made clear in the name so IMO 'BookingService#findAllBookings' seems very exhaustive and explicit. 10:36 - same point for this as the one mentioned above. 'BookingService' already indicate that it handles bookings and therefore, 'deleteByCode' references the code of booking(s). 29:29 - why would one NEVER reference the 'Collection' type? It's useful in many cases, and quite frankly required a lot. Feel free to prove me wrong if there are reasonable doubt and arguments to the points mentioned. As a backend programmer myself, I would be glad to receive said thoughts as we can never stop learning. Other than that; fun video, Amigos!

@StarzzDrak

2 жыл бұрын

about the 9:50 and 10:36, it's never wrong or useless to be more explicit. You've got IDE helping you write all long names, but when it comes to reading it and tracing back it's always good to be more explicit, even if it's inside a type

@oliwer4987

2 жыл бұрын

@@StarzzDrak Of course. Don't get me wrong, I'm not saying it's not; what I am saying is that it is not a better practise nor is it needed. Quite frankly, I feel it's unnecessarily long. If you prefer to name it that way, go for it, but it's already indicated so in reality it's all good. In this case there was even multiple repositories, so even inheritance would do good with the original naming.

@adrianroed2178

2 жыл бұрын

​@@StarzzDrak Being explicit is good, but being concise is also important. I can't claim to be an authority on the best balance of explicit vs concise, but there is such a thing as being too explicit. It's the same as in 7:40. I don't think it is necessary to explicitly state every class you're importing, the domain names are explicit enough while being far more concise. To me, "listAll" is explicit enough, because this is the class "BookingService", it is the controller for the class "BookingDTO" and all it's functions implicitly refer to booking DTO. If for some reason listAll returned anything other than booking DTO I would agree that it needed to be more explicit.

@onebacon_

2 жыл бұрын

7:40 couldn't be more right. Explicit imports are just noise in your code and don't contribute anything

@gilzemer8113

2 жыл бұрын

@@StarzzDrak "it's never wrong or useless to be more explicit" I strongly disagree. For example, if you have a class Person with fields like "name", "age", "address", it is better to have methods like "getName()", "getAge()" and "getAddress()", and not "getPersonName()", "getPersonAge()" and "getPersonAddress()". when the code is "person.getName()", it is clear to the user what the name field is refering to, however "person.getPersonName()" just makes the code inflated for no good reason. This is just a simple example but of course it applies to the case covered in the video as well. if you have a booking service, bookingService.getById(), bookingService.getByCode() is clear enough, no need to inflate the code with the obvious context (booking)

Awesome video man! I'm an experienced Java developer and I'm planning to take one of your online courses, because I'm learning a lot with you. Now, I want to argue with you in one thing. I think that the BookingService should actually return a BookingDTO upon insertion. This is because, when you send a 200 CREATED status, usually you send back a link to the newly created resource, so the client can actually send a GET request afterwards. In fact, mostly of the time the client will insert the new resource and do something with it afterwards(adding to a list on the UI, for example). So, sending the created entity avoids having to do a second request. If returning the whole Entity/DTO may cause a overhead, then at least the generated ID should be returned, so you can build the link for the client. Well, this is my opinion. Congratulations again for the video!

Thank you for making more of these!

20:30 honestly calling findAll on a repository and doing filtering in code is a huge code smell. you're loading an entire DB table into memory just to filter out one single entry. best case: it's just bad code, worst case: your operating cost explodes because of the memory consumption, also latency. the filter itself should be contained within a specialized DB query to the likes of (pseudo-SQL:) "WHERE startDate before now AND confirmed == true" then "ORDER BY start date ASC" and "LIMIT 1",. the repository method returns an Optional, since you're actually only interesented in one entry (which could not exist, e.g. if you don't have any bookins yet, therefore Optional). BOOM, your code just became extremely trivial. also don't forget DB indexes on startDate and confirmed DB fields fro proper DB query performance ;)

@adamk2251

2 жыл бұрын

also, regarding RESTfulness: when adding new resources, you don't return void and 200 OK, you do return the saved entity with the generated UUID and respond with a 201 Created. a HTTP DELETE is supposed to be idempotent, which means that performing the same request several times should have the same effect. thefefore you shouldnt be returning a 404 when the entity to be deleted doesn't exist, just give a 204 No Content response (since the effect that the request asked for happened: the entity to be deleted does not exist after the request is completed).

@adamk2251

2 жыл бұрын

but apart from that, great video, i pretty much agree with the way you structure and format the code and your way of thinking, love that you use assertJ. great educational stuff!

@mm1nt

2 жыл бұрын

Thanks for the tips. Appreciate it

@verrigo

2 жыл бұрын

@@adamk2251 Yes. I was about to comment on this, but glad someone else did it before me :D

@volbla

2 жыл бұрын

So basically keep a properly organized database instead of bodging in code?

Here comes the incredible Nelson. Kuddos to you bro you are the best

Nice video, please make more of these, I'm hooked!... A series of these would actually make us better java developers🙂💯!!!!;

This helped me refactor my own project

Amigos thanks for taking the time to explain this topic

This is great stuff! Thanks for these!

It was amazing and I learn alot from your video, keep grinding

Great video. For other watching, if you use findAll and filter afterwards its going to impact performance on a large dataset, always try to put your filtering inside your query (jparepository). You can even put your min max inside there.

I love this goofy format!

It is amazing! Looking forward to see more!

Thanks. Please continue this series.

Wow. Thanks a lot for this video. This is more helpful. Please drop more videos like this.

Please bring again same videos for code reviews asap. These are amazing and you are doing great work. Thanks a lot!! Please bring asap...

I would love to see more code refactoring videos like this.

Love your videos and this series a lot. Which font do you use for intelliJ? Is that the default JetBrains Mono?

hello, thanks for your demonstration how we can be better coding.

I love this channel btw -- Subscribed

Amazing Video, I love how you explain why you should refactor the code like you do here, it helps to get a way better view on the structure. Also I really appreciate you for showing the good approach of testing, am really pumped to implement tests into my backends to see some of the green bars

Love this content! Thank you~

More of this series please!!! 👍

This is really good. Plz do more of such stuff.

This is great, please make more of these

Thanks you so much amigoscode for this kind of videos

Walikum Alsalam, Gaza’s Allah Khair…. Loving you code ❤️😘

السلام عليكم.. hello brother.. thanks for everything you did for people.. suliman from SaudiArabia ❤

It's amazing. I always learn something new from your videos.

@rafa16chagas

Жыл бұрын

Amazing. How do I get my prize?

Very useful video. Thank you for your efforts

Great video, I got a lot of knowledge and experience

Awesome, super helpful thank you so much :)

Powerful Teaching Methods Here, Thanks very much!

Thank you for your contribution 🙏

When you "Assalamualikum", it made me so happy!!

Great content. I hoped my code was under your keen eyes. May be next time inshaallah

This is so useful! Thanks

On the delete booking by code (and other situations like that), rather than have them void, I like to return a bool stating where the delete was successful, for instance if an unknown code is passed it may be useful when using that function to know whether the action was successful or not and structure the logic accordingly

I like your good heart Sir Well done

Hello, Would be nice to have a Spring's course about Relation between tables, the cascades, constraints, when to use REST microservice or direct relation in module, joins, and other sql stuff ;)

Useful video. Thanks man

This is great stuff. I'm tempted to do a kotlin equivalent.

The Legendary Hero walking around at 1st flat of the dungeon, hanging with the children:d

Walaikumsalaam warehmatullahi wabarakaatuhuu...Love from Kashmir💖

Love this series!

Useful material, i like it!

Definitely do more of these videos.

thank you so much for the content!!!

Nice video brother, I would like to see best practices advice for Rest API

Amazing 🤩 keep going bro ♥️🙏

Asalamoalaikom Nelson, great as always brother

Amazing nelson 🙌🏾🙌🏾

Best coder around!

amazing series!

Wow mashAllah, thank you so much brother, really useful stuff!!!

never new i'd be very interested in refactoring Thank you !

Very usefull. Next time the code review could be a Spring Rest controller test with mocking.